Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance filterTiles with scoring, filtering, and sorting #1547

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Enhance filterTiles with scoring, filtering, and sorting #1547

merged 2 commits into from
Oct 10, 2024

Conversation

ibek
Copy link
Contributor

@ibek ibek commented Oct 9, 2024 •
edited by lordrip
Loading

  • Implement scoring logic based on search term matches in name, title, and description
  • Filter tiles by score, selected tags, and providers
  • Sort filtered tiles by descending score
  • Group the sorted tiles by their type
Before After
image image

fix: #1557

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f95f50e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/ui/src/components/Catalog/Catalog.tsx 0.00% 9 Missing ⚠️
packages/ui/src/components/Catalog/filter-tiles.ts 95.83% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1547   +/-   ##
=======================================
  Coverage        ?   80.00%           
  Complexity      ?      272           
=======================================
  Files           ?      276           
  Lines           ?     7831           
  Branches        ?     1493           
=======================================
  Hits            ?     6265           
  Misses          ?     1505           
  Partials        ?       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lordrip
Copy link
Member

lordrip commented Oct 10, 2024

Thanks @ibek for the contribution, now is easier to find the right items.

@lordrip lordrip merged commit f0ac182 into KaotoIO:main Oct 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ranked search for the catalog
2 participants
@ibek @lordrip